Ensure crash in commit/rollback does not try twice #34
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that if during the rollback or commit command that there may be a disk error that will cause SQLite to return an error. When that happens we must not attempt to rollback again. This was seen when running multi-threaded and a bug in some code resulted in the SQLite file descripter being closed in the middle of a transaction.
mr-russ
force-pushed
the
safe-rollback
branch
from
c4896b3
to
96d2e7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that if during the rollback or commit command
that there may be a disk error that will cause SQLite to return
an error. When that happens we must not attempt to rollback again.
This was seen when running multi-threaded and a bug in some code
resulted in the SQLite file descripter being closed in the middle of
a transaction.